feat(deps): add tealdeer (tldr) v1.8.1#116
feat(deps): add tealdeer (tldr) v1.8.1#116axel-kaliff wants to merge 2 commits intoprojectbluefin:mainfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request integrates the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds tealdeer as a new dependency, which is a great addition. The packaging follows the existing pattern for similar tools. I've left a few suggestions to improve the maintainability of the new BuildStream elements by reducing code duplication. Specifically, I've suggested moving common sources to the .inc file and consolidating the install commands for better readability.
d916b48 to
8f67479
Compare
Pre-built musl binaries for x86_64 and aarch64 with bash/zsh/fish shell completions. Installs as /usr/bin/tldr.
8f67479 to
3454172
Compare
|
I'll get to this soon, sorry been focusing on the pipeline! |
Summary
/usr/bin/tldrwith bash, zsh, and fish shell completionsDetails
Follows the same BuildStream packaging pattern as glow, gum, and fzf:
tealdeer.bst).inc)kind: remotewithfilename:(tealdeer publishes standalone binaries, not tarballs)All source SHA256 hashes verified against the official GitHub release.
Testing Done
just build— element built and cached successfully)just show-me-the-future, confirmedtldrbinary present)Note
Users will need to run
tldr --updateon first use to download the page cache.